apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: [PATCH] APR WCE
Date Tue, 29 Jan 2002 07:52:12 GMT
From: "William A. Rowe, Jr." <wrowe@covalent.net>
Sent: Tuesday, January 29, 2002 1:25 AM


> From: "Mladen Turk" <mturk@mappingsoft.com>
> Sent: Monday, January 28, 2002 3:48 PM
> 
> > Some more work on the subject...
> > 
> --- dso.c 28 Jan 2002 15:56:08 -0000 1.27
> +++ dso.c 28 Jan 2002 21:44:57 -0000
> @@ -158,8 +164,14 @@
>                           struct apr_dso_handle_t *handle, 
>                           const char *symname)
>  {
> -    *ressym = (apr_dso_handle_sym_t)GetProcAddress(handle->handle, symname);
> +#if _WIN32_WCE
> +    apr_wchar_t wsymname[256];
>  
> +    MultiByteToWideChar(CP_ACP, 0, symname, strlen(symname), wsymname, 255);
> +    *ressym = (apr_dso_handle_sym_t)GetProcAddressW(handle->handle, wsymname);
> +#else
> +    *ressym = (apr_dso_handle_sym_t)GetProcAddress(handle->handle, symname);
> +#endif
>      if (!*ressym) {
> 
> 
> Your SEM changes in this file are fine.  But you cannot use MBtWC.  APR is
> implemented in terms of a single charset.  GStein has asked that we be able
> to change that, which we might at some point.  But it's absolutely unacceptable
> to go from narrow mapping to another.  Please replace with the utf-8 -> unicode
> change so we can get this one commited.
> 
> This is one platform where 'local' charset is senseless - map it all utf-8 and
> you have a 1:1 mapping to the one-and-only charset on CE :)

I just reread this... ick.  Please go to the standard mechanisms for both CE and
WinNT family (just as if it were a filename.)  You caught me asleep at the wheel,
I thought I was near done with fooA symbols on NT :)

BTW - you need to add your recent APR_HAS/HAVE additions to apr.h.in.  No more
patches committed till I get that patch :)

Bill






Mime
View raw message