apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: cvs commit: apr/threadproc/win32 proc.c
Date Tue, 29 Jan 2002 02:52:03 GMT
From: "Brian Havard" <brianh@kheldar.apana.org.au>
Sent: Monday, January 28, 2002 9:33 PM


> On 28 Jan 2002 21:58:16 -0000, gstein@apache.org wrote:
> 
> >gstein      02/01/28 13:58:16
> >
> >  Modified:    include  apr_thread_proc.h
> >               threadproc/beos proc.c
> >               threadproc/netware proc.c
> >               threadproc/os2 proc.c
> >               threadproc/unix proc.c
> >               threadproc/win32 proc.c
> >  Log:
> >  Add a couple new command types to process creation:
> >  
> >      APR_PROGRAM_ENV: start the program using the caller's environment
> >      APR_PROGRAM_PATH: search PATH for the program, use caller's env
> >  
> >  (the normal APR_PROGRAM isolates the env and does not use PATH)
> >  
> >  The BeOS, OS/2, and Win32 implementations are incomplete. These two
> >  new forms just default back to APR_PROGRAM for now. (although BeOS
> >  doesn't even distinguish between APR_SHELLCMD and APR_PROGRAM!)
> >  
> >  On Unix and Netware, these map into execv() and execvp() calls.
> 
> Wouldn't it be simpler to just have env==NULL imply using the parent's
> environment? That is in fact already the case in the OS/2 implementation
> (and Win32 by the looks of it).

+ 1 ... this patch [appeared] overly complex in the first place.  
With an env value passes that array of envvars.  Without simply passes 
the current environment.

Bill


Mime
View raw message