Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Dec 2001 14:35:53 -0800
From: Greg Stein <gstein@lyra.org>
To: dev@apr.apache.org
Subject: Re: cvs commit: apr-util/build apu-conf.m4
Message-ID: <20011205143553.E29959@lyra.org>
Mail-Followup-To: dev@apr.apache.org
References: <20011205182305.69909.qmail@icarus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20011205182305.69909.qmail@icarus.apache.org>;
 from jerenkrantz@apache.org on Wed, Dec 05, 2001 at 06:23:05PM -0000

On Wed, Dec 05, 2001 at 06:23:05PM -0000, jerenkrantz@apache.org wrote:
>...
>   +AC_DEFUN(APU_CHECK_DB2,[
>   +apu_found_db=0
>   +AC_CHECK_HEADER(db2/db.h, [
>      AC_CHECK_LIB(db2, db_open, [
>      apu_have_db=1
>   +  db_header=db2/db.h
>   +  db_lib=db2
>   +  db_version=2
>   +  apu_found_db=1
>   +  ])])
>   +if test $apu_found_db = 0; then
>   +AC_CHECK_HEADER(db.h, [
>   +  AC_CHECK_LIB(db, db_open, [
>   +  apu_have_db=1
>      db_header=db.h
>      db_lib=db
>   -  ])])])
>   +  db_version=2
>   +  apu_found_db=1
>   +  ])])
>   +fi
>   +])

Why did you introduce apu_found_db when apu_have_db is available?

There are a bazillion variables in there. Let's try to simplify :-)

(I might even suggest apu_found_db is redundant, given db_version)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/