From dev-return-5185-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Dec 14 20:42:24 2001 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 35231 invoked by uid 500); 14 Dec 2001 20:42:24 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 35219 invoked from network); 14 Dec 2001 20:42:24 -0000 Date: Fri, 14 Dec 2001 12:42:25 -0800 From: Aaron Bannert To: dev@apr.apache.org Subject: Re: [PATCH] Add --with-efence option. Message-ID: <20011214124225.O1529@clove.org> Mail-Followup-To: Aaron Bannert , dev@apr.apache.org References: <20011214103336.GW1439@ebuilt.com> <20011214092954.G1529@clove.org> <20011214174423.GB1439@ebuilt.com> <20011214095302.H1529@clove.org> <20011214180028.GD1439@ebuilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011214180028.GD1439@ebuilt.com> User-Agent: Mutt/1.3.23i X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Fri, Dec 14, 2001 at 10:00:28AM -0800, Justin Erenkrantz wrote: > > Maybe I'm missing something, but I don't see how the library runtime > > path would have any bearing on an AC test. It either links or it fails, > > right? > > Okay, say we do that. Remember that AC_TRY_RUN will compile, link, > and run. By that time we've done the following: > > LDFLAGS="-Lpath/to/efence/lib -Rpath/to/efence/lib" > LIBS="-lefence" > > The autoconf tests are handled by $CC *not* libtool. A linker that > doesn't understand -R will die. We don't use libtool until the > make process begins. Which means we need the platform-specific > runtime linker flag at configure time. When we do make, we can > rely on libtool handling the -R though. > > However, say we don't add the platform specific link flag, then all > runs will fail on -R needing platforms since we linked against > efence, but didn't specify where its runtime path was. -- justin Justin and I have come up with a proposal. (Justin: I'll expect you to correct me if I misrepresent you.) Why don't we rename some variables: INCLUDES --> AP_INCLUDES LIBS --> AP_LIBS --> AP_LDFLAGS As we do our autoconf tests, we would slowly accumulate flags in the AP_* vars as we do now with INCLUDES and LIBS, but right now we don't have a protected LDFLAGS that won't get picked up by the AC tests. For the above case with efence we'd do: (pseudo-code): AP_INCLUDES += "-I/path/where/we/found/efence/includes" AP_LIBS += "-lefence" AP_LDFLAGS += "-L/path/where/we/found/efence/libs -R/path/where/we/found/efence/libs" -aaron