apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: [PATCH] Add --with-efence option.
Date Fri, 14 Dec 2001 17:29:54 GMT
On Fri, Dec 14, 2001 at 02:33:36AM -0800, Justin Erenkrantz wrote:
> I was using Electric Fence when I was debugging the pool code.
> It helped a bit, so it might be good to have it as a configure 
> option (--with-efence[=DIR]).
> 
> However, I'm wondering if we could have a GPL v. BSD disrepency
> here since efence is under GPL and we're still BSD.  So, I won't 
> commit unless someone says it is okay.
> 
> Note that this requires the addition of the 
> apr_platform_runtime_link_flag variable so that we can properly
> do the LDFLAGS on certain OSes (Solaris).  Linux has -rpath, but
> I'm not 100% sure we need it.  Also, the latest GNU binutils says
> that its ld accepts -R as well - can anyone confirm this on 
> older Linux boxen?  (It seems that setting it to -Wl,-rpath screws
> up the APR_ADDTO macro.)  -- justin
...
> @@ -131,12 +131,15 @@
>  fi
>  
>  dnl On AIX, libraries need to be specified on the link of lib_target
> +lib_target_libs=""
>  case $host in
>      *aix*)
>          lib_target_libs="\$(EXTRA_LIBS)";
>          ;;
> +    *-solaris2*)
> +        apr_platform_runtime_link_flag="-R"
> +        ;;
>      *)
> -        lib_target_libs=""
>          ;;
>  esac
>  
> @@ -184,6 +187,23 @@

The -R flag shouldn't need to be solaris specific. Libtool interprets -R
and -rpath in the same way, and it turns it into whatever is appropriate
for the local linker. So just add -rpath (or -R if you prefer) always
for all platforms.

-aaron

Mime
View raw message