Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 46973 invoked by uid 500); 11 Nov 2001 04:05:28 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 46962 invoked from network); 11 Nov 2001 04:05:28 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Sat, 10 Nov 2001 20:12:36 -0800 From: Greg Stein To: Jeff Trawick Cc: dev@apr.apache.org Subject: Re: apr_dbm_private.h decls of apr_dbm_type_foo Message-ID: <20011110201236.A24954@lyra.org> Mail-Followup-To: Jeff Trawick , dev@apr.apache.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from trawick@attglobal.net on Sat, Nov 10, 2001 at 10:04:57PM -0500 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, Nov 10, 2001 at 10:04:57PM -0500, Jeff Trawick wrote: > So should these be static or extern? (I guess extern). > > apr_dbm_type_foo are all declared static in apr_dbm_foo.c but extern > in apr_dbm_private.h These should be changed to extern in > apr_dbm_foo.c, right? > > Example: > > -static const apr_dbm_type_t apr_dbm_type_gdbm = { > +APU_DECLARE_DATA const apr_dbm_type_t apr_dbm_type_gdbm = { > > I'm kinda guessing at how the code will change when I suggest that it > should be extern. Right now, it works okay as static since > apr_dbm_foo.c is included by apr_dbm.c. You're quite right! I'll get it patched up. I have some more changes to submit tonite (was travelling the past couple days and did some of this work today on the plane). Cheers, -g -- Greg Stein, http://www.lyra.org/