apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject [PATCH] Re: mmap_setaside?
Date Wed, 14 Nov 2001 07:44:57 GMT
Cliff Woolley wrote:

>On Sat, 10 Nov 2001, Brian Pane wrote:
>
>>Is anybody working on modifying mmap_setaside so that it doesn't
>>have to memcpy the file contents?  (I recall this being an issue
>>a while ago.)  This could yield a small but measurable improvement
>>on requests that aren't handled using sendfile
>>
>
>I have worked on it in the past but haven't actively looked at in several
>weeks now.  It's a tricky issue... the last time I looked at it, here's
>what I came up with:
>
>http://marc.theaimsgroup.com/?l=apr-dev&m=100335839408391&w=2
>

Thanks for the pointer.  Here's my attempt to work around the problem that
you noted in that message--the fact that the apr_mmap_t cleanup function
isn't accessible from within mmap_setaside.  My solution was to add a 
pointer
to the cleanup function as an extra field in the apr_mmap_t.

In this patch, I've only tried to optimize for the case where the 
destination
pool is an ancestor of the current pool.  For disjoint pools, it will still
do the big memcpy.

--Brian



Mime
View raw message