apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject [PATCH] speedups for mod_mime and apr_hash_t
Date Wed, 07 Nov 2001 08:08:11 GMT
The mod_mime per-dir-merge function is one of the most computationally
expensive parts of the httpd, due to all of the hash table merges that
it does.  It has accounted for about 15% of the total user CPU time in
recent benchmarks.

This patch attempts to solve the problem by adding two new functions to
apr_hash_t:
  apr_hash_copy()  /* fast shallow copy of a hash table */
  apr_hash_merge() /* like apr_hash_overlap, but it lets you supply a
                      callback function to handle collisions... */

The changes to mod_mime use these new functions to reduce the amount
of copying required for a dir-merge.

Note: depending on how effective this patch is, it may eliminate the
need for the "static pre-merge of per-dir configs" patch that I posted
a while back.

--Brian



Mime
View raw message