apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: cvs commit: apr-util/build apu-conf.m4
Date Thu, 29 Nov 2001 18:27:56 GMT
On Thu, Nov 29, 2001 at 10:22:56AM -0800, Justin Erenkrantz wrote:
> Look at line 134.  The default was already there.  I think you just
> missed that.  =)

yup, forgot about those completely. :)

> > I'm confused, you replaced APU_FIND_DB with less of the same code. What
> > about db_185? The old function was more robust by ensuring the apu_have_db
> > was set to 0 before calling the other functions.
> If it does not equal 1, then it better equal 0.  If you want, you could
> just reverse the logic so that it checks for 0.  Since it is going to
> a preprocessor conditional anyway, zero and non-zero are the appropriate
> values.  Feel free to change.  I don't think it is necessary and the
> setting to 0 was redundant, IMHO.  -- justin

Sounds good to me. I completely missed the != 1. That's what I get for
sending email before the sand is cleared from my eyes.


View raw message