apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] time-space tradeoff (reuse tpool, one CV per worker thread)
Date Sat, 24 Nov 2001 05:26:51 GMT
[ Moving this part of the discussion to dev@apr. ]

On Fri, Nov 23, 2001 at 03:16:35PM -0800, Brian Pane wrote:
> Thanks.  Here's my patch to optimize away the mutex operations in
> pools that have been designated thread-private.  With the current
> worker code, it can eliminate the mutex ops for subrequest pool
> creation/destruction.  By combining it with your worker redesign,
> I think we may be able to eliminate the mutexes for the ptrans
> pool.

Nice idea.  However, I think it might be best to resurrect
Sander's patch which did a rewrite of the pool code (keeping
virtually the same API) but made the internal code much cleaner.  
And, it had thread-private to boot.  (The current pool code has
threads grafted on to it, so it isn't as clean.)  And, we proved
it was a performance win, too, I think.

I remember having this conversation a few months ago, but now
I think might be the time to land this puppy in the tree.  =)
Sander?

My $.02.  -- justin


Mime
View raw message