apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: apr_dbm_private.h decls of apr_dbm_type_foo
Date Sun, 11 Nov 2001 04:12:36 GMT
On Sat, Nov 10, 2001 at 10:04:57PM -0500, Jeff Trawick wrote:
> So should these be static or extern?  (I guess extern).
> 
> apr_dbm_type_foo are all declared static in apr_dbm_foo.c but extern
> in apr_dbm_private.h  These should be changed to extern in
> apr_dbm_foo.c, right?
> 
> Example:
> 
> -static const apr_dbm_type_t apr_dbm_type_gdbm = {
> +APU_DECLARE_DATA const apr_dbm_type_t apr_dbm_type_gdbm = {
> 
> I'm kinda guessing at how the code will change when I suggest that it
> should be extern.  Right now, it works okay as static since
> apr_dbm_foo.c is included by apr_dbm.c.

You're quite right!

I'll get it patched up. I have some more changes to submit tonite (was
travelling the past couple days and did some of this work today on the
plane).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message