apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: apr-util/dbm apr_dbm_berkeleydb.c apr_dbm_gdbm.c apr_dbm_sdbm.c
Date Thu, 08 Nov 2001 21:21:00 GMT
On Thursday 08 November 2001 11:46 am, jerenkrantz@apache.org wrote:
> jerenkrantz    01/11/08 11:46:44
>
>   Modified:    dbm      apr_dbm_berkeleydb.c apr_dbm_gdbm.c apr_dbm_sdbm.c
>   Log:
>   We are calling abort(), so we should include stdlib.h.

A library should NEVER call abort.  If you need to cause the program to die,
then you should return a value and let the program handle it cleanly.  Dieing
inside a library is just wrong.

-1 for this change, the correct approach is to remove the abort calls.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message