apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: APR OS2 file_io bug/problem
Date Wed, 28 Nov 2001 03:19:42 GMT

----- Original Message ----- 
From: "Barry Pederson" <barryp@yahoo.com>
To: "William A. Rowe, Jr." <wrowe@covalent.net>
Sent: Tuesday, November 27, 2001 9:12 PM
Subject: Re: APR Win32 file_io bug/problem


> "William A. Rowe, Jr." wrote:
> 
> > > Given what you've said though, it looks like the OS/2 apr_dir_read() is
> > > wrong then, since it returns APR_SUCCESS without checking to see if it
> > > provides everything in the "wanted" flag.  Maybe it needs that line from
> > > the win32 code:
> > >
> > >      return ((wanted & ~finfo->valid) ? APR_INCOMPLETE : APR_SUCCESS);
> > >
> > > instead of just
> > >
> > >      return APR_SUCCESS;
> > 
> > I agree, 100%.  Suggest you post that at dev@apr.apache.org so Brian Havard
> > can take a peek.
> 
> Actually, I'm not subscribed to that list and probably won't be
> following APR that closely (just wanted to get the subversion import
> working on my box).  
> 
> If you think it's worth pursuing, could you post it or forward this to
> Brian, or whatever you think is appropriate.  

I'll do both ;)

Actually, since OS2 _never_ has symlinks, this code is closer to the truth [and some
versions of Win32 should do so as well]

return ((wanted & ~(finfo->valid|APR_FINFO_LNK)) ? APR_INCOMPLETE : APR_SUCCESS);




Mime
View raw message