Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 1 Oct 2001 14:32:08 -0400 (EDT)
From: Cliff Woolley <cliffwoolley@yahoo.com>
To: <dev@apr.apache.org>
Subject: apr_file_close bug?
Message-ID: 
 <Pine.LNX.4.33.0110011426370.7085-100000@deepthought.cs.virginia.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


On Unix, apr_file_close looks like this:

APR_DECLARE(apr_status_t) apr_file_close(apr_file_t *file)
{
    apr_status_t rv;

    if ((rv = apr_unix_file_cleanup(file)) == APR_SUCCESS) {
        apr_pool_cleanup_kill(file->cntxt, file, apr_unix_file_cleanup);
        return APR_SUCCESS;
    }
    return rv;
}


So if file_cleanup fails, then we won't kill the cleanup, and when we
cleanup the file->cntxt pool, we'll run the cleanup again.  We used to
have this exact same behavior in the directory cleanups and it caused
segfaults.

I think it should just say this:

{
    apr_pool_cleanup_kill(file->cntxt, file, apr_unix_file_cleanup);
    return apr_unix_file_cleanup(file);
}

Which is exactly equivalent to what apr_dir_close() does now that it's
been fixed.  Thoughts?

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA