apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/locks/unix proc_mutex.c
Date Tue, 23 Oct 2001 19:45:47 GMT
Aaron Bannert <aaron@clove.org> writes:

> locks/unix/crossproc.c:392 is still using errno, should this be changed
> as well to only rely on apr_file_mktemp's return value?
> 
>     if (rv != APR_SUCCESS) {
>         apr_status_t stat = errno;
> 
>         fcntl_cleanup(new);
>         return stat;
>     }

you betcha...  

apr_file_open() and apr_file_mkstemp() have to return the right error
code (what caused the operation to fail), so rv has the right value
already.

Thanks,
-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message