apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] apr_proc_wait
Date Tue, 23 Oct 2001 16:50:06 GMT
Ryan Bloom <rbb@covalent.net> writes:

> This patch implements my idea for a new API to apr_proc_wait and 
> apr_proc_all_wait.

<nitpick>
I'm a wee bit nervous that we use an enumerated type for a bitmask.
Using an enumeration for the values of the bits seems fine but maybe
using some unsigned int value is best?  We'd expect an enumerated type
to hold only the values in the enumeration, not some OR of some of
them.
</nitpick>

<seeing the forest in spite of the trees>
but overall this is an important improvement so +1 for committing it,
and if by some chance something breaks or a tweak is needed later we
can easily handle it.
</seeing the forest in spite of the trees>

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message