apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/locks/unix proc_mutex.c
Date Fri, 26 Oct 2001 02:00:13 GMT
trawick@apache.org writes:

> trawick     01/10/25 07:52:43
> 
>   Modified:    locks/unix proc_mutex.c
>   Log:
>   Change proc_mutex_fcntl_create() to remove the lock file.  There was
>   no logic to unlink() the lock file when the user specified the name,
>   though when the APR temporary file facility was used it would be
>   unlinked when closed.

This gets restart working again for worker MPM.

>   -/*    unlink(new_mutex->fname); */
>   +    /* XXX currently, apr_file_mktemp() always specifies that the file should
>   +     *     be removed when closed; that unlink() will fail since we're 
>   +     *     removing it here; we want to remove it here since we don't need
>   +     *     it visible and we want it cleaned up if we exit catastrophically
>   +     */
>   +    unlink(new_mutex->fname);

Frankly, shirley, whatever, I think apr_file_mktemp() needs a
parameter to specify the disposition of the file: remove immediately,
remove at close, don't remove at all.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message