Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
From: "Sander Striker" <striker@apache.org>
To: <dev@httpd.apache.org>,
	<dev@apr.apache.org>
Subject: RE: [PATCH] fix cleanups in cleanups
Date: Fri, 21 Sep 2001 09:51:30 +0200
Message-ID: <JLEGKKNELMHCJPNMOKHOEEPNEJAA.striker@apache.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <20010921003452.X4050@lyra.org>
Importance: Normal

> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: 21 September 2001 09:35
> On Thu, Sep 20, 2001 at 07:54:22PM -0700, Ryan Bloom wrote:
> > On Thursday 20 September 2001 05:48 pm, Greg Stein wrote:
> ....
> > > Calling pop_cleanup() on every iteration is a bit much. Consider the
> > > following patch:
> > 
> > Why is it a bit much?  I just took a quick look at it, it is an 
> if, and three assignments.
> 
> Heh. It is a bit much when you consider you consider a thread in October
> 1999 discussing using NULL rather than ap_null_cleanup:
> 
> http://www.humanfactor.com/cgi-bin/cgi-delegate/apache-ML/nh/1999/
> Oct/0189.html
> 
> In that case, an "if" was considered too much :-)

I always wondered about that.  It seems so silly to have to pass in
apr_pool_cleanup_null allmost all the time as second argument.  It isn't
very clear for first time users and certainly not intuitive.  Oh well,
Manoj pointed this out aswell in that thread and still we have 
apr_pool_cleanup_null...

Sander