Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 19 Sep 2001 02:42:28 -0700
From: Greg Stein <gstein@lyra.org>
To: Ian Holsman <IanH@cnet.com>
Cc: dev@apr.apache.org
Subject: Re: cvs commit: apr/locks/win32 thread_cond.c
Message-ID: <20010919024228.G4050@lyra.org>
Mail-Followup-To: Ian Holsman <IanH@cnet.com>, dev@apr.apache.org
References: <20010918213803.98914.qmail@icarus.apache.org>
 <20010918180322.J2914@lyra.org>
 <1000867984.27766.7.camel@c1619481-a.almda1.sfba.home.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <1000867984.27766.7.camel@c1619481-a.almda1.sfba.home.com>;
 from IanH@cnet.com on Tue, Sep 18, 2001 at 07:53:04PM -0700

On Tue, Sep 18, 2001 at 07:53:04PM -0700, Ian Holsman wrote:
> On Tue, 2001-09-18 at 18:03, Greg Stein wrote:
> > On Tue, Sep 18, 2001 at 09:38:03PM -0000, rbb@apache.org wrote:
>...
> > >   +static apr_status_t thread_cond_cleanup(void *data)
> > >   +{
> > >   +    apr_thread_cond_t *cond = data;
> > >   +    if (cond->num_waiting != 0) {
> > >   +        printf("somebody's waiting, but I'm closing it anyway.\n");
> > 
> > Can't have a printf() in there. Not sure what the right answer is; maybe
> > call the pool's abort function.
> 
> you >could< use the apr_file_printf function 
> and use stderr from the apr_open_stderr call.
> this gets put into the log files, the std fprintf doesnt.

That doesn't change anything. The general policy is that APR is a library,
so it shouldn't be outputing to *any* file descriptor.

Who knows what FD 2 is bound to? Only the app does. Maybe that is a binary
file it is constructing. You sure don't want to spam it with text.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/