apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [PATCH] performance improvement for apr_pstrcat
Date Thu, 27 Sep 2001 02:05:34 GMT
Ryan Bloom wrote:

>On Wednesday 26 September 2001 06:57 pm, Brian Pane wrote:
>
>>Ryan Bloom wrote:
>>
>>[...]
>>
>>>+    static const int MAX_SAVED_LENGTHS = 6;
>>>
>>>Why is this a static const istead of a #define?
>>>
>>So that its scope will be limited to the enclosing function
>>
>
>But why is that a good thing?  This should be a compile time limit set with
>a simple macro.
>

If you think there's a use for it outside this function, I have
no objection to moving the declaration up to file scope.

--Brian




Mime
View raw message