apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/file_io/unix mktemp.c
Date Mon, 24 Sep 2001 20:44:53 GMT
On Mon, Sep 24, 2001 at 01:20:09PM -0700, Ryan Bloom wrote:
> On Monday 24 September 2001 01:19 pm, Greg Stein wrote:
> > On Mon, Sep 24, 2001 at 06:44:08AM -0700, Ryan Bloom wrote:
> > > On Monday 24 September 2001 12:41 am, Greg Stein wrote:
> > >...
> > >
> > > > Those perms are incorrect. The APR function takes different perms than
> > > > the Unix functions. That should be APR_UREAD|APR_UWRITE.
> > >
> > >...
> > > They didn't used to be different.  Okay.  I'll fix this today.
> >
> > They've had those values since you first checked them in, way back August
> > of 1999.
> >
> > (boy, the annotate feature in ViewCVS is useful...)
> 
> Yeah, but the values that I checked in are the same as the Unix values.

Um, yah. That was what my comment was all about. When you converted the
mkdir() to apr_dir_make(), the perms also had to change.

I meant APR_U* and friends have always been hex-based rather than
octal-based ever since your first checkin.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message