apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/locks/win32 thread_cond.c
Date Wed, 19 Sep 2001 09:42:28 GMT
On Tue, Sep 18, 2001 at 07:53:04PM -0700, Ian Holsman wrote:
> On Tue, 2001-09-18 at 18:03, Greg Stein wrote:
> > On Tue, Sep 18, 2001 at 09:38:03PM -0000, rbb@apache.org wrote:
>...
> > >   +static apr_status_t thread_cond_cleanup(void *data)
> > >   +{
> > >   +    apr_thread_cond_t *cond = data;
> > >   +    if (cond->num_waiting != 0) {
> > >   +        printf("somebody's waiting, but I'm closing it anyway.\n");
> > 
> > Can't have a printf() in there. Not sure what the right answer is; maybe
> > call the pool's abort function.
> 
> you >could< use the apr_file_printf function 
> and use stderr from the apr_open_stderr call.
> this gets put into the log files, the std fprintf doesnt.

That doesn't change anything. The general policy is that APR is a library,
so it shouldn't be outputing to *any* file descriptor.

Who knows what FD 2 is bound to? Only the app does. Maybe that is a binary
file it is constructing. You sure don't want to spam it with text.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message