apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject [PATCH] minor to apr_thread_mutex routines
Date Wed, 05 Sep 2001 18:43:52 GMT
Simple patch that removes what appear to be useless includes from the
apr_thread_mutex.h header. Also adds an include to the implementation
to get rid of a memset() compiler warning (thanks to Justin for pointing
this out).

(Less unnecessary includes in header files means less dependencies and
smaller&faster incremental builds :)

-aaron


Index: include/arch/unix/thread_mutex.h
===================================================================
RCS file: /home/cvspublic/apr/include/arch/unix/thread_mutex.h,v
retrieving revision 1.1
diff -u -r1.1 thread_mutex.h
--- include/arch/unix/thread_mutex.h	2001/09/04 23:28:50	1.1
+++ include/arch/unix/thread_mutex.h	2001/09/05 18:33:50
@@ -58,15 +58,12 @@
 #include "apr.h"
 #include "apr_private.h"
 #include "apr_general.h"
-#include "apr_lib.h"
 #include "apr_thread_mutex.h"
-#include "apr_sms.h"
 #include "apr_portable.h"
 
 #if APR_HAVE_PTHREAD_H
 #include <pthread.h>
 #endif
-/* End System Headers */
 
 #if APR_HAS_THREADS
 struct apr_thread_mutex_t {
Index: locks/unix/thread_mutex.c
===================================================================
RCS file: /home/cvspublic/apr/locks/unix/thread_mutex.c,v
retrieving revision 1.1
diff -u -r1.1 thread_mutex.c
--- locks/unix/thread_mutex.c	2001/09/04 23:28:51	1.1
+++ locks/unix/thread_mutex.c	2001/09/05 18:33:50
@@ -54,6 +54,11 @@
 
 #include "thread_mutex.h"
 
+#if APR_HAVE_STRING_H
+/* this gives us memset() */
+#include <string.h>
+#endif
+
 #if APR_HAS_THREADS
 
 static apr_status_t thread_mutex_cleanup(void *data)

Mime
View raw message