apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/threadproc/win32 thread.c
Date Fri, 03 Aug 2001 11:36:14 GMT
FYI...  You should commit all closely related changes at once (e.g.,
your various implementations of apr_thread_yield()), assuming that you
had them ready at the same time.

See minor nit below:

bnicholes@apache.org writes:

>   Index: thread.c
>   ===================================================================
>   RCS file: /home/cvs/apr/threadproc/win32/thread.c,v
>   retrieving revision 1.34
>   retrieving revision 1.35
>   diff -u -r1.34 -r1.35
>   --- thread.c	2001/07/24 20:20:02	1.34
>   +++ thread.c	2001/08/03 00:31:43	1.35
>   @@ -173,6 +173,11 @@
>        }
>    }
>    
>   +APR_DECLARE(void) apr_thread_yield()

Shouldn't this have another "void", as in

     APR_DECLARE(void) apr_thread_yield(void)

With no parameter list declaration it looks like K&R.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message