apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/threadproc/unix thread.c
Date Wed, 01 Aug 2001 21:25:55 GMT
Aaron Bannert <aaron@ebuilt.com> writes:

> I posted a fix for this about a week and a half ago. The fix attempted
> to do the same thing on other platforms. Also, my fix made one extra
> change (that may or may not be agreeable to the group), and that was to
> change the prototype of apr_thread_exit() so it takes an apr_status_t
> instead of an (apr_status_t*). This was because the original method
> essentially required the return status (which is just an (int)) to be
> allocated from the heap merely so it could be passed back through
> thread_join() (or analog in all cases except os2). By making it a
> non-pointer the caller doesn't have to worry about where the memory for
> the (int) was allocated, because it's immediately copied.

That sounds better...  I remembered something being done with thread
status codes but assumed it had already been committed.

I'll try to find some time in the next 24hrs to look over the patch
and hopefully commit, assuming nobody voices any disagreements.

Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message