apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: cvs commit: apr-util/buckets apr_brigade.c
Date Thu, 16 Aug 2001 16:20:46 GMT
On 16 Aug 2001 rbb@apache.org wrote:

> rbb         01/08/16 00:13:07
>
>   Modified:    buckets  apr_brigade.c
>   Log:
>   If we ask to partition a brigade past the end of the brigade, that is
>   not an error condition.  At worst, that is a STATUS condition, that we
>   should report to the caller, namely, we didn't really partition this,
>   because there wasn't enough in the brigade to partition.  We should also
>   return a pointer to the SENTINEL bucket, so that we can split the
>   brigade successfully.
>
>   This fixes a seg fault in mod_ssl for Apache.
>
>   -    return APR_EINVAL;
>   +    *after_point = APR_BRIGADE_SENTINEL(b);
>   +    return APR_INCOMPLETE;

Hmmmmmm.... well, okay.  But now we're even further overloading
APR_INCOMPLETE.  I'm not sure that's what we want.  I'll have to think
about this some more.

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message