apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mladen Turk" <mt...@mappingsoft.com>
Subject [PATCH] WIN9x - Apache has caused an error in LIBAPR.DLL
Date Sat, 11 Aug 2001 14:30:46 GMT
Hi all,

I think that someone noticed that when shutting down the Apache on WIN9x
platform you get the exclamation error box stating : "Apache has caused an
error in LIBAPR.DLL ...." ?

Here is a small patch that solves that problem.

The error is in locks/win32/locks.c lock_cleanup function that gets the NULL
as a function parameter. I wasn't able to track the source of the call that
send the NULL value to apr_lock_destroy but here is the patch that checks if
the function value is NULL and returns not APR_SUCCESS in such a case

--- locks.c.old	Thu Jul 19 17:26:36 2001
+++ locks.c	Sat Aug 11 16:03:34 2001
@@ -63,6 +63,8 @@
 {
     apr_lock_t *lock = lock_;

+	if (!lock)
+	    return APR_EINVAL;
     switch (lock->type)
     {
     case APR_MUTEX:


Well, the code speaks for itself

MT.


Mime
View raw message