apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <I...@cnet.com>
Subject Re: cvs commit: apr-util/test Makefile.in
Date Thu, 23 Aug 2001 03:36:32 GMT
On Wed, 2001-08-22 at 20:25, Greg Stein wrote:
> -1 on this change. Please back out.
> 
I patched this twice. 
(first time to build with 'default' configure, 2nd to get it working
with db/gdbm DBMs option)

is the 2nd patch better?

ALL_LIBS +=  @APRUTIL_EXPORT_LIBS@
(and all references to expat are removed)

(Holding off on reversing till I hear back)
..ian

> Expat might not be located in xml/expat. It is entirely possible/reasonable
> that we found Expat already installed on the system.
> 
> Look at apr-util/build/apu-conf.m4 for more information. Specifically: we
> should have already put the expat libs into the LIBS symbol. If it isn't
> making it into the LIBS symbol in test/Makefile.in, then there is another
> problem -- and your patch is not solving that problem.
> 
> Cheers,
> -g
> 
> On Wed, Aug 22, 2001 at 09:32:14PM -0000, ianh@apache.org wrote:
> > ianh        01/08/22 14:32:14
> > 
> >   Modified:    test     Makefile.in
> >   Log:
> >   add some the expat libs to the link line, and change it from LIB to ALL_LIB so
that
> >   it can link.
> >   
> >   Revision  Changes    Path
> >   1.14      +7 -7      apr-util/test/Makefile.in
> >   
> >   Index: Makefile.in
> >   ===================================================================
> >   RCS file: /home/cvs/apr-util/test/Makefile.in,v
> >   retrieving revision 1.13
> >   retrieving revision 1.14
> >   diff -u -r1.13 -r1.14
> >   --- Makefile.in	2001/08/07 23:02:40	1.13
> >   +++ Makefile.in	2001/08/22 21:32:14	1.14
> >   @@ -9,21 +9,21 @@
> >    test: $(PROGRAMS)
> >    
> >    testdbm_OBJECTS = testdbm.lo
> >   -testdbm_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la
> >   +testdbm_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la ../xml/expat/lib/libexpat.la
> >    testdbm: $(testdbm_OBJECTS) $(testdbm_LDADD)
> >   -	$(LINK) $(testdbm_OBJECTS) $(testdbm_LDADD) $(LIBS)
> >   +	$(LINK) $(testdbm_OBJECTS) $(testdbm_LDADD) $(ALL_LIBS)
> >    
> >    testdate_OBJECTS = testdate.lo
> >   -testdate_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la
> >   +testdate_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la ../xml/expat/lib/libexpat.la
> >    testdate: $(testdate_OBJECTS) $(testdate_LDADD)
> >   -	$(LINK) $(testdate_OBJECTS) $(testdate_LDADD) $(LIBS)
> >   +	$(LINK) $(testdate_OBJECTS) $(testdate_LDADD) $(ALL_LIBS)
> >    
> >    testxml_OBJECTS = testxml.lo
> >    testxml_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la ../xml/expat/lib/libexpat.la
> >    testxml: $(testxml_OBJECTS) $(testxml_LDADD)
> >   -	$(LINK) $(testxml_OBJECTS) $(testxml_LDADD) $(LIBS)
> >   +	$(LINK) $(testxml_OBJECTS) $(testxml_LDADD) $(ALL_LIBS)
> >    
> >    testmd4_OBJECTS = testmd4.lo
> >   -testmd4_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la
> >   +testmd4_LDADD =  ../libaprutil.la @APR_SOURCE_DIR@/libapr.la ../xml/expat/lib/libexpat.la
> >    testmd4: $(testmd4_OBJECTS) $(testmd4_LDADD)
> >   -	$(LINK) $(testmd4_OBJECTS) $(testmd4_LDADD) $(LIBS)
> >   +	$(LINK) $(testmd4_OBJECTS) $(testmd4_LDADD) $(ALL_LIBS)
> >   
> >   
> >   
> 
-- 
Ian Holsman
Performance Measurement & Analysis
CNET Networks    -    415 364-8608

Mime
View raw message