apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] LDAP extension to apr-util (take 2)
Date Mon, 13 Aug 2001 20:37:33 GMT
Ryan Bloom wrote:

> Then this is the only thing that should be in apr_ldap.  If we are trying to
> create a wrapper library to abstract out differences in all of the other
> LDAP libraries, then I _might_ be able to get behind that.

Ok.

> None of that stuff belongs in apr-util.  This has nothing to do with portability,
> this has to do with attaching LDAP to a web server.  If this is something that
> we want to provide as a standard part of Apache, not sure we do (haven't
> thought about it much), then it should be a part of the module that attaches
> the two together, not a part of the abstraction library.

So this should be part of Apache - now for the next question - should it
be an Apache module, or part of the Apache core?

> If these routines are not meant to be an abstraction layer for all LDAP
> libraries, then they do not belong in APR or APR-util.

Ok, I propose this:

- The linking-to-miriad-of-different-ldap-libraries function, and the
small bit in apr_ldap_compat.c that smooths out differences between
functions in LDAP v2 and v3 should go in APR-util (or APR?). (This patch
is small and easy to review.)

- The LDAP connection-reuse / compare cache should be abstracted into
their own module in the Apache tree (under modules/ldap/) that provides
additional LDAP services to modules that need them.

I'd like to get consensus on this before I leap into more code...
(looking for some +1's)

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."
Mime
View raw message