apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: [PATCH] performance fix for time offset computation
Date Tue, 28 Aug 2001 19:52:55 GMT
On Tuesday 28 August 2001 12:32, Greg Stein wrote:
> On Tue, Aug 28, 2001 at 11:15:41AM -0700, Brian Pane wrote:
> > Here's a new version of the get_offset patch that initializes
> > the TZ offset from apr_initialize.  I've attached the new include
> > file that it uses, apr/include/arch/unix/internal_time.h
>
> I don't like Ryan's suggestion for a whole new header just to prototype a
> single function. Lets used arch/unix/misc.h for this instead.

I don't like putting things in the wrong place.  The whole misc thing was one
of my biggest mistakes with APR.  If we can't label what the feature is doing,
we shouldn't do it.

This really belongs in a separate time.h header file.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message