apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr-util/test Makefile.in
Date Thu, 23 Aug 2001 03:52:38 GMT
On Wed, Aug 22, 2001 at 08:36:32PM -0700, Ian Holsman wrote:
> On Wed, 2001-08-22 at 20:25, Greg Stein wrote:
> > -1 on this change. Please back out.
> > 
> I patched this twice. 
> (first time to build with 'default' configure, 2nd to get it working
> with db/gdbm DBMs option)

I did run into your second patch ... didn't see it before reading the first
checkin :-)

> is the 2nd patch better?
> 
> ALL_LIBS +=  @APRUTIL_EXPORT_LIBS@
> (and all references to expat are removed)

I don't know if that += is portable to, say, BSD make. Never seen it before
in a Makefile. I'd be awfully leery about it. Is there another way to get
the export libs in there? IOW, can't the @...@ be inserted at the same place
that ALL_LIBS is initially defined?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message