apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: apr/threadproc/win32 thread.c
Date Fri, 03 Aug 2001 16:15:56 GMT
From: "Jeff Trawick" <trawick@attglobal.net>
Sent: Friday, August 03, 2001 6:36 AM


> FYI...  You should commit all closely related changes at once (e.g.,
> your various implementations of apr_thread_yield()), assuming that you
> had them ready at the same time.

With one discrepancy ... please don't commit the httpd changes with the
base apr changes.  The messages don't always cross correctly.  It's simpler
and safer just to commit the apr/apr-util changes from the srclib tree,
and then commit the impact changes to httpd.


> >   +APR_DECLARE(void) apr_thread_yield()
> 
> Shouldn't this have another "void", as in
> 
>      APR_DECLARE(void) apr_thread_yield(void)
> 
> With no parameter list declaration it looks like K&R.

That was Roy's opinion (thanks for the fixing :)


Mime
View raw message