apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: APR_INCOMPLETE confusion
Date Fri, 03 Aug 2001 15:34:44 GMT
From: "Jeff Trawick" <trawick@attglobal.net>
Sent: Friday, August 03, 2001 7:28 AM

> I'm happy to create a new APR_INCOMPLETE_CHAR status, hijack the
> current doc for APR_INCOMPLETE, and change Apache/APR as appropriate.
> Does APR_INCOMPLETE (for incomplete file status) need to be renamed as
> well for clarity?  APR_INCOMPLETE_STATUS may be sufficiently clear.
> Comments?

the list seems to have an issue with the proliferation of error result codes.  
I don't have a set opinion on this, and certainly a few more will be warrented 
over time.

The flavors I can see are;

APR_SUCCESS   processed all input, provided all expected output

APR_???       processed all input, can only provide some expected output
              (generally a system limitation, such as stat)

APR_???       processed some input, but remaining input is _invalid_
              (as apr_xlate means, are we expecting more input?)

APR_???       processed some input, have more output but the output buffer
              is filled (apr_xlate treats this as APR_SUCCESS, which probably 
              isn't entirely healthy.)

More thoughts?

> On Sunday 29 July 2001 17:36, Marc Slemko wrote:
> > apr_errno.h says:
> >
> >  * APR_INCOMPLETE     The character conversion stopped because of an
> >  *                    incomplete character or shift sequence at the end
> >  *                    of the input buffer.
> >
> > This doesn't seem to be a good description of what it is used for
> > in reality...  since it seems to be used for functions that can return
> > partially filled structures.
> >
> > Could someone who is positive of what it is used for maybe update this
> > comment to make it less misleading?
> -- 
> _____________________________________________________________________________
> Ryan Bloom                        rbb@apache.org
> Covalent Technologies rbb@covalent.net
> -----------------------------------------------------------------------------

View raw message