apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_negotiation.c
Date Tue, 28 Aug 2001 01:52:09 GMT
Well it was busted.  Bad.  Reactivated your patch, Jeff, and started
stepping...

The simple test is set your browser language to en and request;

http://www2.rowe-clan.net:8080/error/HTTP_NOT_FOUND.html.var

If you error 406, the seek (APR_CUR, -value) doesn't work correctly.
It got as far as language de, read the body, and never backspaced 
properly to get the next header line.

If you error 506, then we are in the negotation bug (or mod_includes
anti-recursion bug), and clear of our apr file read/buffered seek
fooness.  This bug is a bigger pita, but at least you will know the
apr_file_read/seek stuff is good :)

The win32 patch is committed.  If we reseek I'm certain we aught to
reset the hit_eof flag.  Be certain your platform is updated.

OTOH, this whole schema is a bit bogus - implemented buffered files
three different ways to sunday is no way to build a reliable library :(

Bill



----- Original Message ----- 
From: "Jeff Trawick" <trawick@attglobal.net>
To: <dev@httpd.apache.org>
Cc: <httpd-2.0-cvs@apache.org>
Sent: Monday, August 27, 2001 3:42 PM
Subject: Re: cvs commit: httpd-2.0/modules/mappers mod_negotiation.c


> trawick@apache.org writes:
> 
> > trawick     01/08/24 04:35:58
> > 
> >   Modified:    modules/mappers mod_negotiation.c
> >   Log:
> >   temporarily back out the buffering of .var files while folks
> >   have a chance to get APR ungetc working properly on buffered
> >   files
> 
> Is this working on Win32 yet?  
> 
> >   --- mod_negotiation.c 2001/08/24 10:40:04 1.76
> >   +++ mod_negotiation.c 2001/08/24 11:35:58 1.77
> >   @@ -889,7 +889,7 @@
> >        /* We are not using multiviews */
> >        neg->count_multiviews_variants = 0;
> >    
> >   -    if ((status = apr_file_open(map, rr->filename, APR_READ | APR_BUFFERED,
> >   +    if ((status = apr_file_open(map, rr->filename, APR_READ /* | APR_BUFFERED
*/,
> 
> -- 
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...
> 


Mime
View raw message