apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] apr_file_t->fname for a pipe
Date Mon, 23 Jul 2001 17:08:14 GMT
(repeating the msg, Bill, since I inadvertently sent it direct to you
the first time)

"William A. Rowe, Jr." <wrowe@rowe-clan.net> writes:

> From: "Jeff Trawick" <trawick@attglobal.net>
> Sent: Monday, July 23, 2001 11:23 AM
> ;dev
> 
> > apr_pipe_create() sets apr_file_t->fname to
> > 
> >   apr_pstrdup(p, "PIPE")
> > 
> >   (why not just "")
> > 
> > Why not leave it NULL?  I don't see any code to retrieve it.
> > Presumably if somebody is looking at the structure in memory they'll
> > realize that NULL is okay since it is a pipe.
> 
> I made this change to the win32 code some time back.  No adverse affects :)
> Feel free to just port that change forward, it's silly to put a string
> identifier that is so out-of-context and invalid.

but why port the "" forward?  why shouldn't it be NULL everywhere?

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message