apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: warnings with APR_USE_PROC_PTHREAD_SERIALIZE
Date Mon, 02 Jul 2001 16:09:55 GMT
Cliff Woolley <cliffwoolley@yahoo.com> writes:

> On 2 Jul 2001, Jeff Trawick wrote:
> 
> > In create_lock(), initialize as follows before filling in any lock handles:
> >
> > #if APR_HAS_PROC_PTHREAD_SERIALIZE
> >     new->pthread_interproc = NULL;
> > #endif
> > #if APR_HAS_SYSVSEM_SERIALIZE || APR_HAS_FCNTL_SERIALIZE || APR_HAS_FLOCK_SERIALIZE
> >     new->interproc = -1;
> > #endif
> > #if APR_USE_PTHREAD_SERIALIZE
> >     new->intraproc = NULL;
> > #endif
> 
> We didn't catch this part, though.  The apr_lock_t is pcalloc'ed just
> prior to calling create_lock().  Do we really need to do this?  If so,
> feel free to add it in...

no prob, but sanity check the reasoning:

the app may need to know when the pthread handle vs. the int handle is
being used, thus the storing of -1 in the int handle and the NULL in
the pthread handle

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message