apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: apr-util/buckets apr_buckets_file.c
Date Thu, 05 Jul 2001 13:56:38 GMT
On Thu, 5 Jul 2001, Bill Stoddard wrote:

> I am teetering on a -1 for this patch. You are hacking around a more fundamental problem.
> If we cannot fix problems like this w/o impacting the performance of all applications
> need to read files, then APR is seriously broken.

Huh?  If I have a file that I put into a bucket, and I set the offset to
0, so that the bucket refers to the whole file, then the bucket code needs
to respect that, regardless of what else I do with the file.  This is
about making the code orthogonal, so that if I read from the file
someplace else, it doesn't effect my bucket logic.

Besides, we are already into the "the performance of this operation sucks"
segment of the code.

Also, I have a feeling that if the file pointer is already at the correct
location, then the C Run-Time will just return, without doing anything.


> > rbb         01/07/04 17:58:56
> >
> >   Modified:    buckets  apr_buckets_file.c
> >   Log:
> >   We need to ALWAYS do the seek if we are reading from the file.  This is
> >   unfortunate from a performance perspective, but right now, I can have an
> >   offset of 0 in the bucket, but be referring to a file that has been read
> >   from.  If we don't seek before reading from the bucket, we get invalid
> >   data.

Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net

View raw message