apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: warnings with APR_USE_PROC_PTHREAD_SERIALIZE
Date Sun, 01 Jul 2001 22:55:13 GMT

Does this solve the warnings?

Index: locks.h
===================================================================
RCS file: /home/cvs/apr/include/arch/unix/locks.h,v
retrieving revision 1.35
diff -u -d -b -w -u -r1.35 locks.h
--- locks.h     2001/07/01 05:49:44     1.35
+++ locks.h     2001/07/01 22:54:09
@@ -150,9 +150,8 @@
     char *fname;
 #if APR_HAS_SYSVSEM_SERIALIZE || APR_HAS_FCNTL_SERIALIZE ||
APR_HAS_FLOCK_SERIALIZE
     int interproc;
-#endif
-#if APR_HAS_PROC_PTHREAD_SERIALIZE
-    pthread_mutex_t *pthread_interproc;
+#elif APR_HAS_PROC_PTHREAD_SERIALIZE
+    pthread_mutex_t *interproc;
 #endif
 #if APR_HAS_THREADS
     /* APR doesn't have threads, no sense in having an thread lock mechanism.

If so, please apply.

Ryan

On Sun, 1 Jul 2001, Cliff Woolley wrote:

>
> Just a heads up on some warnings I'm getting on Solaris 2.6 where
> APR_USE_PROC_PTHREAD_SERIALIZE is selected:
>
> locks.c: In function `apr_os_lock_get':
> locks.c:344: warning: assignment makes pointer from integer without a cast
> locks.c: In function `apr_os_lock_put':
> locks.c:365: warning: assignment makes integer from pointer without a cast
>
> The problem is that (after macro substitution) my apr_os_lock_t looks like
> this:
>
> struct apr_os_lock_t {
>     pthread_mutex_t *crossproc;
>     pthread_mutex_t *intraproc;
> };
>
> And apr_os_lock_get/put assume that crossproc will be an int (as it is
> with the other serialize methods).
>
> I'd work on this, but it'd probably be easier for somebody who's spent
> more time in the locking code than I have...
>
> --Cliff
>
>
>


_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------


Mime
View raw message