apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] apr_file_t->fname for a pipe
Date Mon, 23 Jul 2001 16:37:48 GMT
From: "Jeff Trawick" <trawick@attglobal.net>
Sent: Monday, July 23, 2001 11:23 AM

> apr_pipe_create() sets apr_file_t->fname to
>   apr_pstrdup(p, "PIPE")
>   (why not just "")
> Why not leave it NULL?  I don't see any code to retrieve it.
> Presumably if somebody is looking at the structure in memory they'll
> realize that NULL is okay since it is a pipe.

I made this change to the win32 code some time back.  No adverse affects :)
Feel free to just port that change forward, it's silly to put a string
identifier that is so out-of-context and invalid.


View raw message