apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: [PATCH] LDAP support for apr-util
Date Tue, 31 Jul 2001 03:14:30 GMT

A couple of things.

1)  This is FAR too large to review.  It would be much easier if we started with something
small,
and allowed the number of functions to grow as we need them.

2)  There are C++ comments littered throughout the code.  We can't use C++ comments, because
many compilers throw up on them.

3)  The apr_ldap.h header file has a bunch of functions that aren't documented at all.  No
function
should ever be committed to APR or APR-util without docs.

4)  The docs for the ldap structures won't generate doxygen docs.  Again, no structure should
ever
be committed that way.

That's it for now.  This is not an exhaustive review, because the patch is too large to spend
that
much time on.

Ryan

On Monday 30 July 2001 15:23, Graham Leggett wrote:
> Hi all,
>
> This is the initial landing of the LDAP support for apr-util.
>
> It has the following purposes:
>
> - Do the job of finding and linking to a suitable LDAP library
> - Add an LDAP search and compare cache for extra performance
> - Provide an LDAP connection cache so that LDAP connections can be
> reused
> - Other good things
>
> The code is based on a port of an auth_ldap module by Dave Carrigan
> released under the Apache licence.
>
> The purpose of posting this code here is to get feedback from people on
> what else needs to be done to this code before it could be accepted for
> inclusion into APR-util.
>
> Stuff that should work:
>
> - If the --with-ldap flag is not specified on the ./configure line, the
> LDAP components should not be built, and no errors should crop up. This
> part of the library defaults to disabled.
>
> - If the --with-ldap flag is specified, it should successfully find and
> link to the OpenLDAP libraries (v1.2.x and v2.0.x), or the Netscape LDAP
> libraries, or the new iPlanet LDAP libraries (untested).
>
> If there is anything within the code that is either broken, or
> implemented incorrectly, please let me know so this can be fixed.
>
> The include file apr_ldap.h.in goes in the include/ directory. The rest
> of the files go
> in a new directory called ldap/
>
> Regards,
> Graham

Ryan
_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------

Mime
View raw message