Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 77557 invoked by uid 500); 26 Jun 2001 15:16:53 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 77508 invoked from network); 26 Jun 2001 15:16:46 -0000 Date: Tue, 26 Jun 2001 08:20:28 -0700 (PDT) From: X-Sender: To: Cc: Subject: Re: cvs commit: apr-util/buckets apr_buckets_mmap.c In-Reply-To: <20010626032033.65264.qmail@apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > PS: I still question the copying of the mmap data into the pool in > pool_setaside()... it seems to me that it's easy for that to accidentally > copy a very large file in its entirety into memory. What am I missing? Your right, this can do that. However, we really can't keep that from happening. In reality, the mmap_setaside function should just map it back to a file opened out of the new pool. Ryan _____________________________________________________________________________ Ryan Bloom rbb@apache.org Covalent Technologies rbb@covalent.net -----------------------------------------------------------------------------