Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 78921 invoked by uid 500); 20 Jun 2001 00:57:39 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 78798 invoked from network); 20 Jun 2001 00:57:38 -0000 X-Authentication-Warning: cobra.cs.Virginia.EDU: jcw5q owned process doing -bs Date: Tue, 19 Jun 2001 20:57:41 -0400 (EDT) From: Cliff Woolley X-X-Sender: To: "Roy T. Fielding" cc: Subject: Re: APR file_io/win32/readwrite.c In-Reply-To: <20010619174945.C1201@waka.ebuilt.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Tue, 19 Jun 2001, Roy T. Fielding wrote: > On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote: > > In the following lines from readwrite.c line 90, should the if() > > conditional clause really be an assignment, or is it a typo? It really > > seems like it should be an equality test to me... > > > > rv = apr_get_os_error(); > > if (rv = APR_FROM_OS_ERROR(ERROR_BROKEN_PIPE)) > > return APR_SUCCESS; > > Definitely a bug. Why isn't it giving a warning? I guess MSVC doesn't warn about such things?? Beats the hell out of me. Obviously we'd have seen it in a gcc warning if it were on the Unix side... --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA