Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 88699 invoked by uid 500); 1 Jun 2001 23:45:31 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 88688 invoked from network); 1 Jun 2001 23:45:31 -0000 Date: Fri, 1 Jun 2001 16:45:09 -0700 From: Justin Erenkrantz To: dev@apr.apache.org Subject: Re: cvs commit: apr/build apr_hints.m4 Message-ID: <20010601164509.X9397@ebuilt.com> References: <20010601003550.95928.qmail@apache.org> <20010531184707.I9397@ebuilt.com> <15127.45171.352919.813247@critterling.garfield.home> <20010601134151.S23560@lyra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010601134151.S23560@lyra.org>; from gstein@lyra.org on Fri, Jun 01, 2001 at 01:41:51PM -0700 X-AntiVirus: scanned for viruses by AMaViS 0.2.1-pre3 (http://amavis.org/) X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > No. apr_hints is a last resort. Actual tests like the AC_TRY_COMPILE() that > Justin did are the right way to do it. We should always try to avoid > hard-coding conditions to the host/library/whatever and *test* for them > instead. Since the thread tests are the first real tests performed by APR's autoconf - any additional CPPFLAGS (or whatnot) will get passed to all subsequent tests. I think this is Jeff's concern (perfectly valid - I have it too). Looking at configure,in, I don't think we could move the threading tests around too much. It looks like it is in the right place. -- justin