apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: BUG???? Locks and never released
Date Wed, 13 Jun 2001 14:36:00 GMT
Justin Erenkrantz <jerenkrantz@ebuilt.com> writes:

> Win32 seems to be missing a apr_pool_cleanup_register() call.  I think
> something along the lines of the following might work, but I don't know.
> -- justin
> 
> Index: locks/win32/locks.c
> ===================================================================
> RCS file: /home/cvspublic/apr/locks/win32/locks.c,v
> retrieving revision 1.36
> diff -u -r1.36 locks.c
> --- locks/win32/locks.c	2001/02/16 04:15:56	1.36
> +++ locks/win32/locks.c	2001/05/25 15:16:04
> @@ -91,6 +91,8 @@
>          newlock->mutex = CreateMutex(&sec, FALSE, fname);
>      }
>      *lock = newlock;
> +    apr_pool_cleanup_register(newlock->cntxt,(void*)new, apr_lock_destroy,
> +                              apr_pool_cleanup_null);
>      return APR_SUCCESS;
>  }

I just committed something along the same lines but with a couple of
tweaks:

1) apr_lock_destroy() has the wrong signature for a cleanup routine
2) the cleanup needs to be removed when the lock is destroyed

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...


Mime
View raw message