apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: APR file_io/win32/readwrite.c
Date Wed, 20 Jun 2001 00:57:41 GMT
On Tue, 19 Jun 2001, Roy T. Fielding wrote:

> On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote:
> > In the following lines from readwrite.c line 90, should the if()
> > conditional clause really be an assignment, or is it a typo?  It really
> > seems like it should be an equality test to me...
> >
> >                 rv = apr_get_os_error();
> >                 if (rv = APR_FROM_OS_ERROR(ERROR_BROKEN_PIPE))
> >                     return APR_SUCCESS;
>
> Definitely a bug.  Why isn't it giving a warning?

I guess MSVC doesn't warn about such things??  Beats the hell out of me.
Obviously we'd have seen it in a gcc warning if it were on the Unix
side...

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message