apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@samba-tng.org>
Subject RE: cvs commit: apr/misc/unix errorcodes.c
Date Mon, 04 Jun 2001 23:25:16 GMT
Hi,

Thanks for bringing the code more into APR policy I guess.

>   -#ifdef APR_MEMORY_ASSERT
>   +#ifdef APR_ASSERT_MEMORY
>    APR_DECLARE(void) apr_sms_assert(apr_sms_t *mem_sys)
>    {
>        apr_sms_t *parent;
>   @@ -249,10 +221,7 @@
>         * tracking ancestors, but in that specific case we issue a
>         * warning.
>         */
>   -    if (!mem_sys->parent_mem_sys)
>   -        return;
>   -
>   -    parent = mem_sys
>   +    parent = mem_sys->parent_mem_sys;

This line should read:
         parent = mem_sys;

The condition is also satified if the memory system itself is
tracking. The naming may be confusing, but this is how it
should be.

>        while (parent) {
>            if (apr_sms_is_tracking(parent))
>                return; /* Tracking memory system found, return 
> satisfied ;-) */

Sander


Mime
View raw message