apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/include apr_time.h
Date Sat, 09 Jun 2001 09:21:33 GMT
This is what I'm talking about.

You make a change. Then you decide to revert it because you say it breaks
something. Then you decide that it really didn't break things after all and
put it back in.

Of course, then we have the whole issue that reordering these things is
potentially bogus in the first place because all the doc in the headers says
otherwise.

Just wtf is up? Can you please try to stop iterating in *source control* and
do it on your machine instead? When I see stuff like this, I have zero faith
in the correctness of the changes. I think "well, he doesn't really know
what is going on; he is just flipping stuff around to see what works;
poke... poke... poke... okay. that one works. let's commit that."

-g

On Sat, Jun 09, 2001 at 06:54:33AM -0000, orlikowski@apache.org wrote:
> orlikowski    01/06/08 23:54:33
> 
>   Modified:    include  apr_time.h
>   Log:
>   Lack of sleep makes Victor the village idiot.
>   
>   Revision  Changes    Path
>   1.39      +2 -2      apr/include/apr_time.h
>   
>   Index: apr_time.h
>   ===================================================================
>   RCS file: /home/cvs/apr/include/apr_time.h,v
>   retrieving revision 1.38
>   retrieving revision 1.39
>   diff -u -r1.38 -r1.39
>   --- apr_time.h	2001/06/09 06:43:44	1.38
>   +++ apr_time.h	2001/06/09 06:54:33	1.39
>   @@ -67,8 +67,8 @@
>     * @package APR Time library
>     */
>    
>   -extern APR_DECLARE_DATA const char apr_month_snames[12][4];
>   -extern APR_DECLARE_DATA char apr_day_snames[7][4];
>   +APR_DECLARE_DATA extern const char apr_month_snames[12][4];
>   +APR_DECLARE_DATA extern const char apr_day_snames[7][4];
>    
>    
>    /* number of microseconds since 00:00:00 january 1, 1970 UTC */
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message