apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/build apr_hints.m4
Date Sat, 02 Jun 2001 05:32:14 GMT
On Fri, Jun 01, 2001 at 08:01:06PM -0400, Jeff Trawick wrote:
> Justin Erenkrantz <jerenkrantz@ebuilt.com> writes:
> > > No. apr_hints is a last resort. Actual tests like the AC_TRY_COMPILE() that
> > > Justin did are the right way to do it. We should always try to avoid
> > > hard-coding conditions to the host/library/whatever and *test* for them
> > > instead.
> > 
> > Since the thread tests are the first real tests performed by APR's
> > autoconf - any additional CPPFLAGS (or whatnot) will get passed to
> > all subsequent tests.  I think this is Jeff's concern (perfectly 
> > valid - I have it too).
> > 
> > Looking at configure,in, I don't think we could move the threading 
> > tests around too much.  It looks like it is in the right place.  
> > -- justin
> 
> So for this particular test on this particular platform we're fine.
> 
> Later, for some other platform we find that we need to test for
> feature foo before we test for threads because feature foo is where we
> figure out that we must enable some libc feature test macro.

Sure. Are you making a point? :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message