Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 53208 invoked by uid 500); 19 May 2001 19:21:07 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 53163 invoked from network); 19 May 2001 19:21:04 -0000 X-Authentication-Warning: cobra.cs.Virginia.EDU: jcw5q owned process doing -bs Date: Sat, 19 May 2001 15:21:07 -0400 (EDT) From: Cliff Woolley X-X-Sender: To: Subject: Re: cvs commit: apr/memory/unix apr_sms.c In-Reply-To: <20010519153545.42434.qmail@apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On 19 May 2001 ben@apache.org wrote: > --- apr_sms.c 2001/05/19 13:53:06 1.3 > +++ apr_sms.c 2001/05/19 15:35:45 1.4 > @@ -193,7 +193,7 @@ > mem_sys->accounting_mem_sys = mem_sys; > > if (parent_mem_sys != NULL){ > - if (mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys){ > + if ((mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys)){ > mem_sys->sibling_mem_sys->ref_mem_sys = &mem_sys->sibling_mem_sys; > } > mem_sys->ref_mem_sys = &parent_mem_sys->child_mem_sys; Just to verify (haven't looked at this section of the code itself yet), assignment IS what's intended here, right? If so, a ((foo = bar) != NULL) might make that more clear. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA