Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <3B06E4E0.DD3961CC@algroup.co.uk>
Date: Sat, 19 May 2001 22:25:52 +0100
From: Ben Laurie <ben@algroup.co.uk>
MIME-Version: 1.0
To: Cliff Woolley <cliffwoolley@yahoo.com>
Cc: dev@apr.apache.org
Subject: Re: cvs commit: apr/memory/unix apr_sms.c
References: <Pine.GSO.4.32.0105191519150.18689-100000@cobra.cs.Virginia.EDU>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Cliff Woolley wrote:
> 
> On 19 May 2001 ben@apache.org wrote:
> 
> >   --- apr_sms.c       2001/05/19 13:53:06     1.3
> >   +++ apr_sms.c       2001/05/19 15:35:45     1.4
> >   @@ -193,7 +193,7 @@
> >        mem_sys->accounting_mem_sys = mem_sys;
> >
> >        if (parent_mem_sys != NULL){
> >   -        if (mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys){
> >   +        if ((mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys)){
> >                mem_sys->sibling_mem_sys->ref_mem_sys = &mem_sys->sibling_mem_sys;
> >            }
> >            mem_sys->ref_mem_sys = &parent_mem_sys->child_mem_sys;
> 
> Just to verify (haven't looked at this section of the code itself yet),
> assignment IS what's intended here, right?  If so, a ((foo = bar) != NULL)
> might make that more clear.

Good point. I foolishly assumed the assignment was intentional - it
still looks like it is, but confirmation from someone who knows would be
good. I agree with != NULL if it is so.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff